Re: [PATCH 2/2] x86: iosf: Add debugfs support

[H. Peter Anvin]

On 08/27/2014 02:40 PM, David E. Box wrote:
> Allows access to the iosf sideband through debugfs.

This would break if compiled without CONFIG_DEBUGFS support, which is
often a requirement for security reasons.

Please conditionalize this code, and if practical move it to a separate
.c file.

Most drivers also have separate config options to enable their specific
debugfs options.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/