Re: [PATCH] radeon: Test for PCI root bus before assuming bus->self

[Alex Deucher]

On Wed, Aug 27, 2014 at 9:32 PM, Dave Airlie <airlied@xxxxxxxxx> wrote:
>> On Wed, Aug 27, 2014 at 3:01 PM, Alex Williamson
>> <alex.williamson@xxxxxxxxxx> wrote:
>>> If we assign a Radeon device to a virtual machine, we can no longer
>>> assume a fixed hardware topology, like the GPU having a parent device.
>>> This patch simply adds a few pci_is_root_bus() tests to avoid passing
>>> a NULL pointer to PCI access functions, allowing the radeon driver to
>>> work in a QEMU 440FX machine with an assigned HD8570 on the emulated
>>> PCI root bus.
>>>
>>> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
>>
>
> Does this mean inside a VM we can't enable pcie 2 speeds?
>
> This could lead to a quite disappointing speed decrease for DMA transfers.

It depends on the sbios, but most boards negotiate the highest speed at boot.

Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/