Re: [PATCH] drivers/xen/evtchn.c: Check failure for evtchn_make_refcounted()

[David Vrabel]

On 28/08/14 16:13, Chen Gang wrote:
> evtchn_make_refcounted() may return failure, so need process the failure
> case. In failure case, it need call unbind_from_irqhandler() just like
> evtchn_unbind_from_user() has done.
> 
> irq_from_evtchn() must be OK when bind_evtchn_to_irqhandler() succeed,
> so need not check it again.
> 
> Also still need remain the closing port code, because when the failure
> occurs, unbind_from_irqhandler() will not close port internally.

None of the evtchn_make_refcounted() failures can occur since we know we
have a valid irq and info at the single call site.

I would like to see this fixed by refactoring the code to remove
evtchn_make_refcounted() by making all irqs for event channels reference
counted.  These no need for this refcounting to be optional.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/