RE: [PATCH 0/4] net: stmmac: Enable Intel Quark SoC X1000 Ethernet support

From: Kweh, Hock Leong
Date: Thu Aug 28 2014 - 21:28:23 EST


> -----Original Message-----
> From: Giuseppe CAVALLARO [mailto:peppe.cavallaro@xxxxxx]
> Sent: Wednesday, August 27, 2014 8:53 PM
> To: Kweh, Hock Leong; David S. Miller
> Cc: netdev@xxxxxxxxxxxxxxx; LKML; Ong, Boon Leong; Rayagond K
> Subject: Re: [PATCH 0/4] net: stmmac: Enable Intel Quark SoC X1000 Ethernet
> support
>
> On 8/27/2014 12:32 PM, Kweh Hock Leong wrote:
>
> hello and thx for these patches that at first glance look ok to me.
> Just some minor remark, in the stmmac I try to align the function parameters
> with the open parenthesis (devm_kzalloc in your case in not aligned).
> Added on copy also Rayagond he tested PCI. I cannot do any test because I
> have no PCI cards.
>
> peppe
>

Hi, noted and will update that in the v2 patch. Looking forward to get more feedback
before sending out the second version. Thanks.


Regards,
Wilson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/