Re: [PATCH 2/3] Fix a bidirectional UDS connect check typo

[Casey Schaufler]

On 8/29/2014 8:02 AM, Lukasz Pawelczyk wrote:
> The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
> bidirectional check that should have checked for mutual WRITE access
> between two labels. Due to a typo the second check was incorrect.
>
> Signed-off-by: Lukasz Pawelczyk <l.pawelczyk@xxxxxxxxxxx>

Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-3.18

> ---
>  security/smack/smack_lsm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 478d99e..00443a9 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -3302,8 +3302,8 @@ static int smack_unix_stream_connect(struct sock *sock,
>  		rc = smk_bu_note("UDS connect", skp, okp->smk_known,
>  					MAY_WRITE, rc);
>  		if (rc == 0) {
> -			rc = smk_access(okp, okp->smk_known, MAY_WRITE, NULL);
> -			rc = smk_bu_note("UDS connect", okp, okp->smk_known,
> +			rc = smk_access(okp, skp->smk_known, MAY_WRITE, NULL);
> +			rc = smk_bu_note("UDS connect", okp, skp->smk_known,
>  						MAY_WRITE, rc);
>  		}
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/