Re: [PATCH 0/4] Tidy up of modules using seq_open()

From: Andrew Morton
Date: Fri Aug 29 2014 - 15:14:32 EST


On Fri, 29 Aug 2014 17:06:36 +0100 Rob Jones <rob.jones@xxxxxxxxxxxxxxx> wrote:

> Many modules use seq_open() when seq_open_private() or
> __seq_open_private() would be more appropriate and result in
> simpler, cleaner code.
>
> This patch sequence changes those instances in IPC, MM and LIB.

Looks good to me.

I can't begin to imagine why we added the global, exported-to-modules
seq_open_private() without bothering to document it, so any time you
feel like adding the missing kerneldoc...

And psize should have been size_t, ho hum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/