Re: [GIT PULL] target updates for v3.17-rc3

[Linus Torvalds]

On Sun, Aug 31, 2014 at 11:59 AM, Nicholas A. Bellinger
<nab@xxxxxxxxxxxxxxx> wrote:
>
> Note that these patches where originally intended for -rc1, but missed
> the merge window.  They are mostly iser-target related bug-fixes, along
> with a few other very minor cleanups.

So this pull request was strictly speaking too late for rc3, but I
went "what the hell, it's small" and pulled it anyway.

And then I get this:

  drivers/target/target_core_transport.c: In function
âtransport_dump_vpd_ident_typeâ:
  drivers/target/target_core_transport.c:956:3: warning: passing
argument 1 of âstrlenâ makes pointer from integer without a cast
[enabled by default]
     len = strlen(len);
     ^
  In file included from include/linux/bitmap.h:8:0,
                   from include/linux/cpumask.h:11,
                   from ./arch/x86/include/asm/cpumask.h:4,
                   from ./arch/x86/include/asm/msr.h:10,
                   from ./arch/x86/include/asm/processor.h:20,
                   from ./arch/x86/include/asm/archrandom.h:26,
                   from include/linux/random.h:81,
                   from include/linux/net.h:22,
                   from drivers/target/target_core_transport.c:26:
  include/linux/string.h:80:24: note: expected âconst char *â but
argument is of type âintâ
   extern __kernel_size_t strlen(const char *);
                          ^

and I just go "Yeah, that broken crap can wait until 3.18 after all".

So it got unpulled.

That "strlen(len)" should clearly be a "strlen(buf)" in that commit
6cfa853ceee4, but equally clearly this pull request was pure and utter
garbage, and that "cleanup" commit was shit that nobody had ever even
bothered to compile.

Thanks, but no. And please never send this kind of untested crap to me again,

                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/