Re: [PATCH net-next v2] r8152: reduce the number of Tx

From: David Miller
Date: Mon Sep 01 2014 - 00:38:31 EST


From: Hayes Wang <hayeswang@xxxxxxxxxxx>
Date: Mon, 1 Sep 2014 02:46:38 +0000

> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> [...]
>> This driver has a loop that iterates MAX_TX times to initialize both
>> the RX and TX buffers.
>>
>> So if they are not equal, it can't possibly work.
>
> Excuse me. I don't find that the "RTL8152_MAX_TX" is used by
> rx buffer. The rx buffer only use "RTL8152_MAX_RX". Although
> the tx buffer size is determined by "rx_buf_sz", the tx buffers
> are independent of rx buffers.

Ok, but that is really confusing code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/