RE: [PATCHv2 1/2] ASoC: simple-card: Fix bug of forgetting decrement DT node's refcount

From: Li.Xiubo@xxxxxxxxxxxxx
Date: Mon Sep 01 2014 - 02:52:35 EST



> > Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx>
> > ---
> > sound/soc/generic/simple-card.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-
> card.c
> > index fd8b045..9e170fe 100644
> > --- a/sound/soc/generic/simple-card.c
> > +++ b/sound/soc/generic/simple-card.c
> > @@ -360,6 +360,7 @@ static int asoc_simple_card_parse_of(struct device_node
> *node,
> > }
> > i++;
> > }
> > + of_node_put(np);
> > } else {
> > ret = asoc_simple_card_dai_link_of(node, dev,
> > dai_link, dai_props, true);
>
> No. np is NULL at end of loop.
>

Well, yes, you are right.

Thanks,

BRs
Xiubo