Re: [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using

[Chen Gang]

On 09/02/2014 01:01 AM, H. Peter Anvin wrote:
> On 09/01/2014 09:08 AM, Paul Gortmaker wrote:
>>>>
>>> diff --git a/init/Kconfig b/init/Kconfig
>>> index ac033c3..f301cc8 100644
>>> --- a/init/Kconfig
>>> +++ b/init/Kconfig
>>> @@ -23,6 +23,12 @@ config CONSTRUCTORS
>>>  config IRQ_WORK
>>>  	bool
>>>  
>>> +config CPU_LITTLE_ENDIAN
>>> +	bool
>>> +
>>> +config CPU_BIG_ENDIAN
>>> +	bool
>>
>> Perhaps you should take a cursory look at what already exists in tree
>> before blindly trying to add more to it?
>>
>> $ git grep CPU_BIG_ENDIAN | wc -l
>> 88
>>
> 
> The whole point of this patchset is to make these already widely-used
> options universal across the tree.
> 

Yeah, maybe the patch comments need be improved (mention about what you
said above) to avoid other members' misunderstanding.

If it is necessary (complete the comments), please let me know (I shall
send patch v2 for it).


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/