Re: [PATCH v3 8/9] usb: chipidea: move usb_otg into struct ci_hdrc

From: Peter Chen
Date: Tue Sep 02 2014 - 06:18:38 EST


On Tue, Sep 02, 2014 at 11:08:32AM +0200, Antoine Tenart wrote:
> Hi,
>
> On Mon, Sep 01, 2014 at 09:13:43AM +0800, Peter Chen wrote:
> > On Fri, Aug 29, 2014 at 04:25:35PM +0200, Antoine Tenart wrote:
> > > On Tue, Aug 26, 2014 at 06:22:40PM +0800, Peter Chen wrote:
> > > > On Fri, Aug 22, 2014 at 05:50:19PM +0200, Antoine Ténart wrote:
> > > >
> > > > If the common usb_otg and usb_phy struct still has another's pointer, you
> > > > may not need to add this patch.
> > >
> > > Except if we want to access the OTG member when not using an USB PHY.
> >
> > If there is no USB PHY, the probe at core.c will turn error.
>
> I meant if we use a PHY from the common PHY framework (struct phy) and
> not one from the USB one (struct usb_phy). The 'struct phy' does not
> have a pointer to an OTG structure.
>

Ok, agree.

--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/