Re: [PATCH] Revert "leds: convert blink timer to workqueue"

[Josh Boyer]

On Tue, Sep 2, 2014 at 5:03 AM, Jiri Kosina <jkosina@xxxxxxx> wrote:
> This reverts commit 8b37e1bef5a6b60e949e28a4db3006e4b00bd758.
>
> It's broken as it changes led_blink_set() in a way that it can now sleep
> (while synchronously waiting for workqueue to be cancelled). That's a
> problem, because it's possible that this function gets called from atomic
> context (tpt_trig_timer() takes a readlock and thus disables preemption).
>
> This has been brought up 3 weeks ago already [1] but no proper fix has
> materialized, and I keep seeing the problem since 3.18-rc1.
>
> [1] https://lkml.org/lkml/2014/8/16/128

FWIW we're seeing it reported in Fedora too.  Perhaps a revert is the
right approach for now.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/