Re: [PATCH 3/5] x86: efi: format EFI memory type & attrs with efi_md_typeattr_format()

From: Matt Fleming
Date: Wed Sep 03 2014 - 08:08:02 EST


On Mon, 01 Sep, at 02:53:38AM, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek <lersek@xxxxxxxxxx>
> ---
> arch/x86/platform/efi/efi.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)

I know this is a straight forward patch in the context of this series,
but you need to include a rationale, so that we know in 6 months, 12
months and 5 years from now why this change made sense.

Something like,

"Reduce the amount of duplicated code by using the helper function"

would be fine.

--
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/