Re: workqueue: WARN at at kernel/workqueue.c:2176

[Peter Zijlstra]

On Thu, Sep 04, 2014 at 10:22:08AM +0800, Lai Jiangshan wrote:
> >  	dest_cpu = cpumask_any_and(cpu_active_mask, new_mask);
> > -	if (task_on_rq_queued(p)) {
> > +	if (task_on_rq_queued(p) || p->state == TASK_WAKING) {
> 
> unrelated question: why we have to stop the cpu even the task is
> not running?

Strictly speaking not needed I suppose; I suppose this was done to
reduce complexity. Setting affinity is a rare operation after all.

Maybe Ingo can remember, this is certainly from before I started poking
at things.. :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/