Re: [PATCH 1/2] perf/x86/intel: Add Haswell-EP uncore support

[Peter Zijlstra]

On Fri, Aug 22, 2014 at 07:29:26AM +0200, Andi Kleen wrote:
> > diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> > index 4785ee8..2485fd9 100644
> > --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> > +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c
> > @@ -883,6 +883,8 @@ static int __init uncore_pci_init(void)
> >  	case 62: /* Ivy Bridge-EP */
> >  		ret = ivbep_uncore_pci_init();
> >  		break;
> > +	case 63: /* Haswell-EP */
> > +		ret = hswep_uncore_pci_init();
> 
> Is the lack of break intentional? If yes please add a /* FALL THROUGH */
> comment.

This does look inconsistent with the surrounding code, which does
suggest it was indeed an oversight and not on purpose.

Zheng?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/