Re: [PATCH 04/19] serial: samsung: Remove support for legacy clock code

From: Paul Bolle
Date: Thu Sep 04 2014 - 05:42:28 EST


[Use Tomasz's new address and add Sylwester.]

On Thu, 2014-09-04 at 11:39 +0200, Paul Bolle wrote:
> On Wed, 2014-07-16 at 16:43 +0200, Tomasz Figa wrote:
> > On 16.07.2014 16:35, Paul Bolle wrote:
> > > On Wed, 2014-07-16 at 16:26 +0200, Paul Bolle wrote:
> > >> On Wed, 2014-07-16 at 14:43 +0200, Tomasz Figa wrote:
> > >>> That's right. Apparently I missed them. I guess that's not critical,
> > >>> though, and could be done in separate patch, right?
> > >>
> > >> This is not critical at all, so that's fine with me.
> > >
> > > Actually, that's only correct if the solution here is to just remove the
> > > (currently) dead code hidden behind CONFIG_SAMSUNG_CLOCK. But if the
> > > solution requires something less trivial, that might be quite wrong.
> > >
> > > So please disregard my comment!
> >
> > The code between those ifdefs is no longer used, because all Samsung
> > platforms use the Common Clock Framework after this series. So I believe
> > we can safely remove this dead code.
>
> The three checks for CONFIG_SAMSUNG_CLOCK can still be seen in v3.17-rc3
> and next-20140903. Should I perhaps submit the trivial patch to remove
> them (and the code they hide) or did things turn out to be more
> complicated?
>
>
> Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/