RE: [RFC PATCH] pm: prevent suspend until power supply events are processed

From: Tc, Jenny
Date: Thu Sep 04 2014 - 12:38:49 EST


If the intention is to prevent suspend while processing the power supply uevents,
Isn't it a good option to use EPOLLWAKEUP? In Android, it's already used by
healthd to achieve the same.

-Jenny

> Subject: Re: [RFC PATCH] pm: prevent suspend until power supply events are
> processed
>
> On 4 September 2014 10:21, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> >>> >> + /* dependent power supplies (e.g. battery) may have changed
> >>> >> + * state as a result of this event, so poll again and hold
> >>> >> + * the wakeup_source until all events are processed.
> >>> >> + */
>
> But isn't this comment still incorrect? Its not about dependent supplies but the race
> between the work-handler and its enqueuing?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a
> message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/