Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

From: Linus Walleij
Date: Thu Sep 04 2014 - 12:56:54 EST


On Sun, Aug 31, 2014 at 5:24 PM, Wang YanQing <udknight@xxxxxxxxx> wrote:

> PL2303 USB Serial devices may has GPIOs, this patch add
> basic PL2303 gpio support.
>
> Known issue:
> If gpios are in use(export to userspace through sysfs interface, etc),
> then call pl2303_release(unplug usb-serial convertor, modprobe -r, etc),
> will cause trouble, so we need to make sure there is no gpio user before
> call pl2303_release.
>
> Signed-off-by: Wang YanQing <udknight@xxxxxxxxx>
> ---
> Note: I sniffed office HXD gpio test program to get
> gpios control protocol with PL2303 RA, so I only
> test it with PL2303 RA and HXA, I don't have HXD,
> but because it is *office* HXD gpio test program,
> so if it doesn't work with HXD, I will feel surprise.
>
> Changes
> v7-v8:
> 1: add support for four dedicated gpios on HXD and RA
> 2: fix problem reported by Johan Hovold in v7
> 3: fix checkpatch.pl's warning

This has been looking nice from the GPIO side of things
for a while so:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/