Re: [PATCH v9 2/3] clk: RK808: Add clkout driver for RK808

[Dmitry Torokhov]

Hi Chris,

On Thu, Sep 04, 2014 at 09:12:38AM +0800, Chris Zhong wrote:
> +	rk808_clkout->clk_data.clks = clk_table;
> +	rk808_clkout->clk_data.clk_num = RK808_NR_OUTPUT;
> +
> +	return of_clk_add_provider(node, of_clk_src_onecell_get,
> +				   &rk808_clkout->clk_data);
> +}
> +
> +static struct platform_driver rk808_clkout_driver = {
> +	.probe = rk808_clkout_probe,
> +	.driver		= {
> +		.name	= "rk808-clkout",
> +	},
> +};

Shouldn't there also be:

static int rk808_clkout_probe(struct platform_device *pdev)
{
	of_clk_del_provider(pdev->dev.of_node);

	/* The rest of resources are managed ones */

	return 0;
}

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/