Re: [PATCH] rtl8188eu: Replace rcu_dereference() with rcu_access_pointer()

[Andreea Bernat]

Hello,

I cloned this:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git

and after moved to staging-next branch, but in both cases, in
those files I don't find any use of rcu_dereference() call (the call
which I am looking for to modify).

Thank you,
Andreea

2014-08-30 23:42 GMT+03:00 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>:
> On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote:
>> The "rcu_dereference()" call is used directly in a condition.
>> Since its return value is never dereferenced it is recommended to use
>> "rcu_access_pointer()" instead of "rcu_dereference()".
>> Therefore, this patch makes the replacement.
>>
>> The following Coccinelle semantic patch was used:
>> @@
>> @@
>>
>> (
>>  if(
>>  (<+...
>> - rcu_dereference
>> + rcu_access_pointer
>>   (...)
>>   ...+>)) {...}
>> |
>>  while(
>>  (<+...
>> - rcu_dereference
>> + rcu_access_pointer
>>   (...)
>>   ...+>)) {...}
>> )
>>
>> Signed-off-by: Andreea-Cristina Bernat <bernat.ada@xxxxxxxxx>
>> ---
>>  drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> This patch fails to apply to my tree, can you refresh it against the
> staging-next branch of the staging.git tree on kernel.org and resend?
>
> thanks,
>
> greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/