Re: [PATCH -v4] x86: only load initrd above 4g on second try

From: Anders Darander
Date: Fri Sep 05 2014 - 01:48:36 EST


* Yinghai Lu <yinghai@xxxxxxxxxx> [140905 03:19]:


> On Thu, Sep 4, 2014 at 2:29 PM, Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:
> > On Thu, 04 Sep, at 01:59:05PM, H. Peter Anvin wrote:

> >> I am fine with this patch, but at the same time I do want to note that
> >> there is an alternative to double-buffer the patch and/or (if that
> >> applies to the buggy BIOS) round up the size of the target buffer.

> > I'm not sure that rounding up the size of the target buffer will
> > workaround this issue correctly.

> > As far as I know, the only thing that Mantas tried was rounding up the
> > size of the source file, by padding it.

> Can you try attached patch on top of linus tree?

I took the liberty to test the patch on my Dell XPS13 9333, and
unfortunately I got the old hang back.

This was tested on the current Linus' tree.

Cheers,
Anders Darander

> - chunksize = size;
> + chunksize = round_up(size, EFI_PAGE_SIZE);



--
It usually takes more than three weeks to prepare a good impromptu speech.
-- Mark Twain
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/