Re: [PATCH] pinctrl: bcm281xx: Add remove function to pinctrl_unregister

From: Linus Walleij
Date: Fri Sep 05 2014 - 04:03:23 EST


On Sat, Aug 30, 2014 at 6:19 PM, Pramod Gurav
<pramod.gurav@xxxxxxxxxxxxxxx> wrote:

> This patch adds a remove function in platform_driver to pinctrl_unregister
> for clean unloading.
> This makes local struct pinctrl_dev a part of struct bcm281xx_pinctrl_data to
> be accessed from pdev in remove function.
>
> CC: Sherman Yin <syin@xxxxxxxxxxxx>
> CC: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Signed-off-by: Pramod Gurav <pramod.gurav@xxxxxxxxxxxxxxx>

Since this driver is a "bool" in Kconfig, it is not loaded as a module
and .remove() is never called.

So this is unnecessary.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/