Re: [PATCH v2 1/4] arm64, thunder: Add Kconfig option for Cavium Thunder SoC Family

From: Russell King - ARM Linux
Date: Fri Sep 05 2014 - 05:33:04 EST


On Fri, Sep 05, 2014 at 09:46:42AM +0200, Robert Richter wrote:
> From: Radha Mohan Chintakuntla <rchintakuntla@xxxxxxxxxx>
>
> Increase maximum numbers of cpus to 32. This relates to current
> maximal possible cpu number. Increasing this to 64 cpus will be a
> separate patch not part of this enablement patches.
>
> Signed-off-by: Radha Mohan Chintakuntla <rchintakuntla@xxxxxxxxxx>
> Signed-off-by: Robert Richter <rrichter@xxxxxxxxxx>
> ---
> arch/arm64/Kconfig | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index fd4e81a4e1ce..77fb82b0f684 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -134,6 +134,11 @@ source "kernel/Kconfig.freezer"
>
> menu "Platform selection"
>
> +config ARCH_THUNDER
> + bool "Cavium Inc. Thunder SoC Family"
> + help
> + This enables support for Cavium's Thunder Family of SoCs.
> +
> config ARCH_VEXPRESS
> bool "ARMv8 software model (Versatile Express)"
> select ARCH_REQUIRE_GPIOLIB
> @@ -256,6 +261,7 @@ config NR_CPUS
> range 2 32
> depends on SMP
> # These have to remain sorted largest to smallest
> + default "32" if ARCH_THUNDER
> default "8"

Why do you need ARCH_THUNDER? If it's just to change this default,
please don't bother - we don't do this kind of thing on x86, so why
should it be done here? Just ensure that NR_CPUS is appropriately
adjusted. Alternatively, look at how x86 deals with this (with
X86_BIGSMP / MAXSMP).

--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/