Re: [PATCH] ext4: Fixed styling issues

From: Christoph Hellwig
Date: Sun Sep 07 2014 - 11:46:46 EST


On Sun, Sep 07, 2014 at 03:16:22PM +0200, Richard Weinberger wrote:
> On Sun, Sep 7, 2014 at 2:45 PM, Daniel Bomar <dbdaniel42@xxxxxxxxx> wrote:
> > Fixed styling issues as reported by scripts/checkpatch.pl
> >
> > Signed-off-by: Daniel Bomar <dbdaniel42@xxxxxxxxx>
>
> Please don't run checkpatch.pl on in-kernel files.

I don't think it's up to us to tell people what files they should run
patches on on.. That doesn't mean that pure style cleanup patches in an
area you don't understand are a good idea, so don't send them. This is
different when you actually do a major overhaul of an area, in which
case I'd actually like to do a first pass of style cleanup and
refactoring before submitting the real work.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/