Re: [PATCH] staging: unisys: uislib: uislib.c: sparse warning of context imbalance

From: Greg Kroah-Hartman
Date: Mon Sep 08 2014 - 13:24:59 EST


On Mon, Sep 08, 2014 at 12:10:55PM -0500, Romer, Benjamin M wrote:
> On Mon, 2014-09-08 at 10:06 -0700, Greg Kroah-Hartman wrote:
> > Traditionally, you would respond with a:
> > Acked-by: Developer Name <email@address>
> > so I can add it to the patch.
> >
> > Care to do that here?
> >
> > thanks,
> >
> > greg k-h
>
> Of course. :)
>
> Acked-by: Benjamin Romer <benjamin.romer@xxxxxxxxxx>
>
> Should I do this instead of Tested-by and Signed-off-by, in the future?

If you test it, do a tested-by.

If you sign off on it (i.e. it flows through you to me), then a
signed-off is correct.

Hope this helps,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/