Re: [PATCH 1/2] iio: vadc: Qualcomm SPMI PMIC voltage ADC driver

[Stanimir Varbanov]

On 09/09/2014 01:32 PM, Arnd Bergmann wrote:
> On Monday 08 September 2014 18:30:00 Stanimir Varbanov wrote:
>>>>> These numbers all look hardware specific, so why put macros into the
>>>>> device tree rather than using them directly?
>>>>
>>>> The idea was to use #defines in DT nodes when we need to overwrite the
>>>> adc channel parameters, see example in 2/2 how it will be used.
>>>
>>> I don't understand. The node in the example has
>>>
>>> +               /* Channel node */
>>> +               usb_id_nopull@39 {
>>> +                       qcom,channel = <VADC_LR_MUX10_USB_ID>;
>>> ...
>>> +               };
>>>
>>>
>>> And VADC_LR_MUX10_USB_ID is defined to 0x39.  How is this helping anything?
>>> You just introduce an artificial dependency on the header file, which makes
>>> it a mess to merge the patches or do updates, and anybody who needs to
>>> make updates to this now has to go through the same pain, to update the
>>> dts files, the driver and the binding document in lockstep.
>>>
>>> Why not remove the qcom,channel property completely and use a 'reg'
>>> property with #address-cells=<1>, #size-cells=<0> and put the number
>>> directly in there, with no need for obfuscation macros?
>>
>> OK thanks for the remarks. I will fix this mess.
>>
>> I hope you are expecting to see this:
>>
>> pmic_vadc: vadc@3100 {
>>         #address-cells = <1>;
>>         #size-cells = <0>;
>>         #io-channel-cells = <1>;
>>         io-channel-ranges;
>>
>>         usb_id_nopull@39 {
>>                 reg = <0x39>;
>>         };
>> };
>>
>> and use the vadc channel from usb device node
>>
>> usb {
>>         ...
>>         io-channels = <&pmic_vadc 0x39>;
>>         io-channel-names = "usbidnopull";
>> };
> 
> The ID stuff looks good now, but I had not noticed the
> "io-channel-names" property before. I think you misunderstood
> the purpose of that, because it is very similar to the name of the
> adc provider (usb_id_nopull@39).
> 
> Like anything else that we refer to by name (interrupt, reg,
> clock, regulator, ...), the name used in the client is supposed
> to be a string that identifies what the connection means to the
> client, not what it means to the provider. This string is
> supposed to be defined in the binding of the client device and
> independent of what other hardware block provides it.

yes of course, my fault. Thanks for clarification.

-- 
regards,
Stan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/