Re: [PATCH v3 25/29] nios2: Module support

[Tobias Klauser]

On 2014-09-10 at 09:29:25 +0200, Chung-Lin Tang <chunglin_tang@xxxxxxxxxx> wrote:
> On 14/9/10 5:25 AM, Valdis.Kletnieks@xxxxxx wrote:
> > On Mon, 08 Sep 2014 17:22:36 +0800, Ley Foon Tan said:
> >> This patch adds support for loadable modules.
> >>
> >> Signed-off-by: Ley Foon Tan <lftan@xxxxxxxxxx>
> > 
> >> +/*
> >> + * Modules should NOT be allocated with kmalloc for (obvious) reasons.
> >> + * But we do it for now to avoid relocation issues. CALL26/PCREL26 cannot reach
> >> + * from 0x80000000 (vmalloc area) to 0xc00000000 (kernel) (kmalloc returns
> >> + * addresses in 0xc0000000)
> >> + */
> > 
> > That's a nice scary comment to see. :)
> > 
> > What's the long-term plan here?
> > 
> 
> We would probably need to add the ability to add trampolines in some
> way, though this of course impairs a little performance. Or if the
> default region of vmalloc can be configured to use the same 256MB region
> as the kernel.
> 
> I wonder how MIPS (which has similar same-region call/jump instructions)
> deals with this?

Please see Arnd's comment on the v2 of this patch [1] for a solution.

[1] http://www.spinics.net/lists/linux-arch/msg27059.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/