Re: [PATCH v4 2/2] usb: gadget: Add xilinx usb2 device support

[Arnd Bergmann]

On Wednesday 10 September 2014 19:25:11 sundeep subbaraya wrote:
> > that's not exactly what I asked  Usually you only add COMPILE_TEST
> > when you have an ARCH dependency. So something like:
> >
> >         depends on ARCH_ARM || COMPILE_TEST
> >
> > would make it clear that this driver is only available on ARM, but when
> > doing my build tests, I'd still be able to compile it on x86.
> 
> Ok got it 

Most of the xilinx stuff also applies to MICROBLAZE however, so it
may need to be

	ARM || MICROBLAZE || COMPILE_TEST

(not ARCH_ARM, btw).

> >> > Also, your code uses device tree functions unconditionally, which is
> >> > fine, but it must hence depend on 'OF'.
> >>
> >> Ok will add OF along with COMPILE_TEST
> >
> > so this would be:
> >
> >         depends on OF || COMPILE_TEST

If it requires OF to build, you can use 'OF && (ARM || COMPILE_TEST)',
but if there is no compile-time dependency, you can just leave out
the 'depends on OF' completely. You can't even build a Zynq machine
without OF enabled.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/