Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context
From: J. Bruce Fields
Date: Wed Sep 10 2014 - 15:34:11 EST
On Wed, Sep 10, 2014 at 03:28:10PM -0400, Jeff Layton wrote:
> Yes, that's the downside of moving to multiple list_heads. Still, I
> think it's worth doing that even if we end up with the code a bit more
> verbose.
>
> It may be best to consider moving some of this into helpers that live
> in locks.c. I really don't like having filesystems poke around in the
> intimate details of the file locking code as a general rule...
I was also wondering whether helpers like for_each_posix_lock() or
first_posix_lock() would be worth it.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/