Re: [PATCH] mmc: dw_mmc: add support for ARM64
From: Jaehoon Chung
Date: Thu Sep 11 2014 - 00:45:17 EST
Hi, Alim.
On 09/11/2014 11:35 AM, Alim Akhtar wrote:
> Hi Jaehoon,
> On Sep 11, 2014 11:18 AM, "Jaehoon Chung" <jh80.chung@xxxxxxxxxxx <mailto:jh80.chung@xxxxxxxxxxx>> wrote:
>>
>> On 09/09/2014 08:31 PM, Alim Akhtar wrote:
>> > Hi Ulf,
>> >
>> > On Tue, Sep 9, 2014 at 12:21 PM, Ulf Hansson <ulf.hansson@xxxxxxxxxx <mailto:ulf.hansson@xxxxxxxxxx>> wrote:
>> >> On 29 August 2014 12:24, Alim Akhtar <alim.akhtar@xxxxxxxxxxx <mailto:alim.akhtar@xxxxxxxxxxx>> wrote:
>> >>> There are upcoming ARM64 SoCs with dw_mmc host controller.
>> >>>
>> >>> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx <mailto:alim.akhtar@xxxxxxxxxxx>>
>> >>> ---
>> >>> drivers/mmc/host/Kconfig | 2 +-
>> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>>
>> >>> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
>> >>> index a43295c..72dd6c2 100644
>> >>> --- a/drivers/mmc/host/Kconfig
>> >>> +++ b/drivers/mmc/host/Kconfig
>> >>> @@ -580,7 +580,7 @@ config SDH_BFIN_MISSING_CMD_PULLUP_WORKAROUND
>> >>> config MMC_DW
>> >>> tristate "Synopsys DesignWare Memory Card Interface"
>> >>> depends on HAS_DMA
>> >>> - depends on ARC || ARM || MIPS || COMPILE_TEST
>> >>> + depends on ARC || ARM || ARM64 || MIPS || COMPILE_TEST
>> >>
>> >> Before enabling this, wouldn't it be better to add the needed support
>> >> in dw_mmc first? Or there are no changes needed?
>> >>
>> >> There are also ongoing development and discussions for exynos7, which
>> >> I guess relates to this?
>> >> http://www.spinics.net/lists/linux-mmc/msg28294.html
>> > Thanks for looking into this.
>> >
>> > Yes, this patch is being tested on exynos7 platform which is ongoing
>> > development.
>> > The above link is one of them.
>> > I feel this patch is too generic in nature and we now known at least
>> > exynos7 is going to use this.
>> > I don't know if there are any other ARM64 platform with dw_mmc controller.
>>
>> If we need to prepare the ARM64, the above patch(linked patch) has to merge, why not?
> I am not in hurry to merge this now, as I said, its upto the maintainers to decide when to take this and I am ok with that.
>> But it needs to test for other SoCs and rework it.
> What rework you are anticipating here?
Sorry for confusing you. (I didn't see the above URL.)
You need to use this patch (http://www.spinics.net/lists/linux-mmc/msg21742.html), right?
Then need to rework it.
Best Regards,
Jaehoon Chung
>
> Thanks.
>>
>> Best Regards,
>> Jaehoon Chung
>>
>> >
>> > So, I am going to leave this upto you to decide when to take this
>> > patch, incase you decided to take it after exynos7 support lands, I
>> > will send a reminder for this.
>> >>
>> >> Kind regards
>> >> Uffe
>> >> --
>> >> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> >> the body of a message to majordomo@xxxxxxxxxxxxxxx <mailto:majordomo@xxxxxxxxxxxxxxx>
>> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> >
>> >
>> >
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/