Re: [PATCH 2/2] ARM: dts: add intmem node for rk3288 smp support

[Doug Anderson]

Kever,

On Wed, Sep 10, 2014 at 3:05 AM, Kever Yang <kever.yang@xxxxxxxxxxxxxx> wrote:
> This patch add intmem node des which is needed by platsmp.c
> and enable the smp.
>
> Signed-off-by: Heiko Stuebner <heiko@xxxxxxxxx>
> Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> ---
>
>  arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
> index dca586e..562ec5f 100644
> --- a/arch/arm/boot/dts/rk3288.dtsi
> +++ b/arch/arm/boot/dts/rk3288.dtsi
> @@ -40,6 +40,7 @@
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>
> +               enable-method = "rockchip,rk3288-smp";
>                 cpu@500 {
>                         device_type = "cpu";
>                         compatible = "arm,cortex-a12";
> @@ -353,6 +354,23 @@
>                 status = "disabled";
>         };
>
> +       bus_intmem@ff700000 {
> +               compatible = "mmio-sram";
> +               reg = <0xff700000 0x18000>;
> +               #address-cells = <1>;
> +               #size-cells = <1>;
> +               ranges = <0 0xff700000 0x18000>;
> +                       smp-sram@0 {

nit: I think the "smp-sram@0" line is indented one too many tabs.

I haven't done a full review of this series yet, though...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/