RE: [PATCH 0/2] usb: dwc2: Revert patches causing problems

[Paul Zimmerman]

> From: gregkh@xxxxxxxxxxxxxxxxxxx [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
> Sent: Thursday, September 11, 2014 1:20 PM
> 
> On Thu, Sep 11, 2014 at 07:11:20PM +0000, Paul Zimmerman wrote:
> > > From: Robert Baldyga [mailto:r.baldyga@xxxxxxxxxxx]
> > > Sent: Thursday, September 11, 2014 5:53 AM
> > >
> > > These two patches breaks dwc2 driver. The first one causes build break,
> > > the second breaks gadget at Samsung platforms.
> > >
> > > Best regards
> > > Robert Baldyga
> > >
> > > Robert Baldyga (2):
> > >   Revert "usb: dwc2: Update Kconfig to support dual-role"
> > >   Revert "usb: dwc2: move "samsung,s3c6400-hsotg" into common platform"
> > >
> > >  drivers/usb/dwc2/Kconfig    | 63 +++++++++++++++++++--------------------------
> > >  drivers/usb/dwc2/Makefile   | 21 +++++++--------
> > >  drivers/usb/dwc2/gadget.c   |  1 +
> > >  drivers/usb/dwc2/platform.c |  1 -
> > >  4 files changed, 38 insertions(+), 48 deletions(-)
> >
> > Yep, I can confirm the build breakage. Greg, we should revert these two
> > before you send your update for the next -rc, if it's not too late.
> >
> > Dinh, before resending the series, please test that each individual
> > patch does not break the build.
> 
> I tested and didn't see the build breakage on my end, but I don't
> test-build arm stuff...
> 
> Anyway, this is in the usb-next branch, not usb-linus, right?

Oops, yes, you're right. So not so urgent I guess. I think we should
still revert, though. The two patches break -next, and are pointless
without the rest of the series.

-- 
Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/