Re: [PATCH/RESEND] tty: serial: msm: Add DT based earlycon support

[Rob Herring]

On Thu, Sep 11, 2014 at 5:14 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
> Add support for DT based early console on platforms with the msm
> serial hardware.
>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

One comment, but looks good to me.

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> +static int __init
> +msm_serial_early_console_setup(struct earlycon_device *device, const char *opt)
> +{
> +       if (!device->port.membase)
> +               return -ENODEV;
> +
> +       device->con->write = msm_serial_early_write;
> +       return 0;
> +}
> +OF_EARLYCON_DECLARE(msm_serial, "qcom,msm-uart",
> +                   msm_serial_early_console_setup);

Don't you want to support kernel command line as well? Then if you
can't change the DT or bootloader's command line, you can add it into
the kernel build with the appended command line. Don't forget to
document it in kernel-parameters.txt if you do.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/