Re: [PATCH v3 3/3] sched: BUG when stack end location is over written

From: Aaron Tomlin
Date: Fri Sep 12 2014 - 05:47:18 EST


On Fri, Sep 12, 2014 at 02:06:57PM +1000, Michael Ellerman wrote:
> On Thu, 2014-09-11 at 16:41 +0100, Aaron Tomlin wrote:
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index a285900..2a8280a 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -824,6 +824,18 @@ config SCHEDSTATS
> > application, you can say N to avoid the very slight overhead
> > this adds.
> >
> > +config SCHED_STACK_END_CHECK
> > + bool "Detect stack corruption on calls to schedule()"
> > + depends on DEBUG_KERNEL
> > + default y
>
> Did you really mean default y?
>
> Doing so means it will be turned on more or less everywhere, which defeats the
> purpose of having a config option in the first place.

Only if Kconfig CONFIG_DEBUG_KERNEL is enabled in the first place.

--
Aaron Tomlin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/