Re: linux-next: Tree for Sep 1

From: Jason Cooper
Date: Sun Sep 14 2014 - 01:41:26 EST


Christoph,

On Tue, Sep 02, 2014 at 10:00:07AM -0500, Christoph Lameter wrote:
> On Tue, 2 Sep 2014, Christoph Lameter wrote:
>
> > Oww.. This is double indirection deal there. A percpu offset pointing to
> > a pointer?
> >
> > Generally the following is true (definition from
> > include/asm-generic/percpu.h that is used for ARM for raw_cpu_read):
> >
> > #define raw_cpu_read_4(pcp) (*raw_cpu_ptr(&(pcp)))
>
> I think what the issue is that we dropped the fetch of the percpu offset
> in the patch. Instead we are using the address of the variable that
> contains the offset. Does this patch fix it?
>
>
> Subject: irqchip: Properly fetch the per cpu offset
>
> The raw_cpu_read() conversion dropped the fetch of the offset
> from base->percpu_base in gic_get_percpu_base.
>
> Signed-off-by: Christoph Lameter <cl@xxxxxxxxx>

Acked-by: Jason Cooper <jason@xxxxxxxxxxxxxx>

thx,

Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/