Re: [PATCH RESEND v9 1/5] rtc: max77686: Allow the max77686 rtc to wakeup the system

From: Javier Martinez Canillas
Date: Mon Sep 15 2014 - 10:03:21 EST


Hello Andrew,

Thanks a lot for taking a look to these patches!

On 09/13/2014 12:05 AM, Andrew Morton wrote:
> On Fri, 12 Sep 2014 10:17:39 +0200 Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> wrote:
>
>> From: Doug Anderson <dianders@xxxxxxxxxxxx>
>>
>> The max77686 includes an RTC that keeps power during suspend. It's
>> convenient to be able to use it as a wakeup source.
>>
>> NOTE: due to wakeup ordering problems this patch alone doesn't work so
>> well on exynos5250-snow. You also need something that brings the i2c
>> bus up before the max77686 wakeup runs.
>
> I removed this paragraph.
>

Great.

>> Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
>
> And I rewrote this to Signed-off-by:, as you were on the patch delivery
> path. Documentation/SubmittingPatches section 12 has the gory details.
>

Yes, originally Doug posted this patch separately but was never picked so I
included on my series but forgot to add my s-o-b and also to remove the note
paragraph.

Best regards,
Javier

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/