Re: [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using
From: Chen Gang
Date: Mon Sep 15 2014 - 18:41:31 EST
On 09/15/2014 09:55 PM, Arnd Bergmann wrote:
> On Sunday 14 September 2014, Chen Gang wrote:
>> Hello Maintainers:
>>
>> Is this patch worthy enough to be applied?
>>
>> Welcome any ideas, suggestions or completions.
>
> I find it hard to judge whether it's worth it or not. You gave one example
> for a driver that needs this, but what would be your estimate on how
> many other drivers have the same problem, either producing a #warning
> or misbehaving if neither symbol is set?
>
For me, it is also hard to judge, so at present, we can assume it is not
worthy enough for other individual modules.
> Having all architectures consistently report the endianess would be nice,
> but we have to weigh the advantages (currently broken code, potential
> simplifications) against the regression risk.
>
Yeah, so our 'goal' is OK, but we need focus on 'how'.
At present, firstly need modify 'init/Kconfig', and then scan all
architectures one by one, let each related patch pass checking by the
related maintainers (which can avoid the risk).
Thanks.
--
Chen Gang
Open share and attitude like air water and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/