Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances

[Jeff Moyer]

Christoph Hellwig <hch@xxxxxxxxxxxxx> writes:

>> Again, the right return value for the O_DIRECT case is EINVAL.
>
> Is it?  We define -EAGAIN as it would block, which is defintively true
> for O_DIRECT reads.

It will *always* block.  So I don't think it's valid to ask for a
non-blocking read on a file opened with O_DIRECT.  What am I missing?

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/