Re: [PATCH] extcon: sm5502: Drop useless include

From: 함명주
Date: Tue Sep 16 2014 - 19:38:16 EST


> Don't include <linux/input.h> when the driver does not use anything
> from this header file.
>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>
> Cc: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>

Acked-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>

Chanwoo, please review/merge the patch when you return.

Cheers,
MyungJoo

> ---
> drivers/extcon/extcon-sm5502.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -17,7 +17,6 @@
>
> #include <linux/err.h>
> #include <linux/i2c.h>
> -#include <linux/input.h>
> #include <linux/interrupt.h>
> #include <linux/irqdomain.h>
> #include <linux/kernel.h>
>
> --
> Jean Delvare
> SUSE L3 Support
>
>
>