Re: [PATCH 09/12] kvm: iommu: Convert to use new iommu_capable() API function

From: Joerg Roedel
Date: Wed Sep 17 2014 - 04:29:50 EST


Hi Paolo, Gleb,

On Fri, Sep 05, 2014 at 12:53:01PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
>
> Cc: Gleb Natapov <gleb@xxxxxxxxxx>
> Cc: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
> ---
> virt/kvm/iommu.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)

Do you have any objections against this patch? I would like to put this
series into the iommu tree.


Thanks,

Joerg

>
> diff --git a/virt/kvm/iommu.c b/virt/kvm/iommu.c
> index 714b949..45ee080 100644
> --- a/virt/kvm/iommu.c
> +++ b/virt/kvm/iommu.c
> @@ -191,8 +191,7 @@ int kvm_assign_device(struct kvm *kvm,
> return r;
> }
>
> - noncoherent = !iommu_domain_has_cap(kvm->arch.iommu_domain,
> - IOMMU_CAP_CACHE_COHERENCY);
> + noncoherent = !iommu_capable(&pci_bus_type, IOMMU_CAP_CACHE_COHERENCY);
>
> /* Check if need to update IOMMU page table for guest memory */
> if (noncoherent != kvm->arch.iommu_noncoherent) {
> @@ -254,8 +253,7 @@ int kvm_iommu_map_guest(struct kvm *kvm)
> }
>
> if (!allow_unsafe_assigned_interrupts &&
> - !iommu_domain_has_cap(kvm->arch.iommu_domain,
> - IOMMU_CAP_INTR_REMAP)) {
> + !iommu_capable(&pci_bus_type, IOMMU_CAP_INTR_REMAP)) {
> printk(KERN_WARNING "%s: No interrupt remapping support,"
> " disallowing device assignment."
> " Re-enble with \"allow_unsafe_assigned_interrupts=1\""
> --
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/