Re: [PATCH 7/7] check for O_NONBLOCK in all read_iter instances

From: Theodore Ts'o
Date: Wed Sep 17 2014 - 09:48:03 EST


On Wed, Sep 17, 2014 at 08:24:48AM -0400, Benjamin LaHaise wrote:
>
> Linus flamed me for that a few weeks ago. The problem is that if one
> uses "git format-patch" to prepare a series of emails to post, that it
> users the patch's author for the From: entry. I think that is a bug
> in git since multiple people have encountered this issue. It's not
> like git doesn't know what one's email address is....

That's true, but "git send-email" takes care of doing the rewrite so
that your e-mail address is on the from line and the original author's
from: line is moved into the body of the e-mail:

% git log -1
commit 1419b5ae0b3bf093bd694dd592ebfdb58ac92d10
Author: Michael Forney <forney@xxxxxxxxxx>
Date: Mon Sep 15 14:30:00 2014 -0400

Don't clear BUILD_CFLAGS and BUILD_LDFLAGS when cross-compiling

Signed-off-by: Michael Forney <forney@xxxxxxxxxx>
Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
% git format-patch -o /tmp/p -1
/tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch
% head -5 /tmp/p/0001-Don-t-clear-BUILD_CFLAGS-and-BUILD_LDFLAGS-when-cros.patch