Re: [PATCH v5 2/4] dt-bindings: document Rockchip thermal

[Caesar Wang]

å 2014å09æ18æ 04:13, Dmitry Torokhov åé:
> On Wed, Sep 17, 2014 at 12:48:16PM -0700, Doug Anderson wrote:
> > Caesar,
> >
> > On Tue, Sep 16, 2014 at 8:59 PM, Caesar Wang <caesar.wang@xxxxxxxxxxxxxx> wrote:
> > > This add the necessary binding documentation for the thermal
> > > found on Rockchip SoCs
> > >
> > > Signed-off-by: zhaoyifeng <zyf@xxxxxxxxxxxxxx>
> > > Signed-off-by: Caesar Wang <caesar.wang@xxxxxxxxxxxxxx>
> > > ---
> > >   .../bindings/thermal/rockchip-thermal.txt          | 41 ++++++++++++++++++++++
> > >   1 file changed, 41 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> > > new file mode 100644
> > > index 0000000..6fc8bc3
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> > > @@ -0,0 +1,41 @@
> > > +* Temperature Sensor ADC (TSADC) on rockchip SoCs
> > > +
> > > +Required properties:
> > > +- compatible: "rockchip,rk3288-tsadc"
> > > +- reg: physical base address of the controller and length of memory mapped
> > > +       region.
> > > +- interrupts: The interrupt number to the cpu. The interrupt specifier format
> > > +             depends on the interrupt controller.
> > > +- clocks: Must contain an entry for each entry in clock-names.
> > > +- clock-names: Shall be "tsadc" for the converter-clock, and "apb_pclk" for
> > > +              the peripheral clock.
> > > +- num-trips:  number of total trip points, this is required, set it 0 if none,
> > > +             if greater than 0, the following properties must be defined;
> > nit: there is whitespace damage (space before tab) on the line before
> > this one.  It's more obvious in the patch you uploaded to gerrit which
> > highlights this in red:
> >
> > https://chromium-review.googlesource.com/#/c/213967/5/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt
> >
> > Did you run your patches through checkpatch before submitting?
> FWIW vim users like me can put the following in their .vimrc file to
> have whitespace damage visible right away:
>
> :highlight RedundantSpaces ctermbg=red guibg=red
> :match RedundantSpaces /\s\+$\| \+\ze\t/
>
> Thanks.

It's a very useful, Thank you  for sharing.


--
Best regards,
Caesar


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/