[PATCH] mfd: core: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

From: Xiubo Li
Date: Thu Sep 18 2014 - 04:22:05 EST

Since we cannot make sure the 'cell->num_resources' will always be none
zero here, and then if either equal to zero, the kzalloc() will return
ZERO_SIZE_PTR, which equals to ((void *)16).

So this patch fix this with just doing the zero check before calling

Signed-off-by: Xiubo Li <Li.Xiubo@xxxxxxxxxxxxx>
drivers/mfd/mfd-core.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index 892d343..54c7e35 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -89,6 +89,9 @@ static int mfd_add_device(struct device *parent, int id,
int ret = -ENOMEM;
int r;

+ if (!cell->num_resources)
+ return -EINVAL;
pdev = platform_device_alloc(cell->name, id + cell->id);
if (!pdev)
goto fail_alloc;

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/