Re: [PATCHv2] pinctrl: baytrail: Clear DIRECT_IRQ bit

[Mika Westerberg]

On Thu, Sep 18, 2014 at 11:31:35AM +0200, Loic Poulain wrote:
> Warn seems necessary because we unconditionally change
> the pin behavior, I didn't meet any case where direct irq is truly
> used on our platform. But maybe it could happen?
> Don't want to cause any hidden regression.

The datasheet says 

"""
This bit should be cleared if io access mode is selected
for this pad
"""

If I interpret it right, it means that whenever this pad is functioning
as a GPIO the flag should be cleared. That's precisely the case here.

> Moreover if it is confirmed that is an hardware issue (BIOS),
> We can just keep this patch locally as a workaround and revert
> it later once our BIOS fixed.

True but only if there aren't any machines out there with this flaw in
the BIOS.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/