Re: [v3 PATCH 1/1] init: fix race between rootfs mount and firmware loading

From: Oleg Nesterov
Date: Thu Sep 18 2014 - 13:44:16 EST


On 09/18, Roman Pen wrote:
>
> +void wait_for_rootfs(void)
> +{
> + /* Avoid waiting for ourselves */
> + if (WARN_ON(is_global_init(current)))
> + return;
> + else
> + wait_event(rootfs_waitq, rootfs_mounted);
> +}

Ah, wait, the is_global_init() check doesn't look right in any case.

What if /sbin/init does sys_init_module() and this module does
request_firmware() ?

I think we should only warn if init is going to wait,

/* Avoid waiting for ourselves */
if (rootfs_mounted || WARN_ON(is_global_init(current)))
return;

__wait_event(rootfs_waitq, rootfs_mounted);


> +EXPORT_SYMBOL(wait_for_rootfs);

Why?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/