Re: [PATCH] mfd: rtsx: fix PM suspend for 5227 & 5249

From: micky
Date: Thu Sep 18 2014 - 21:24:38 EST

On 09/19/2014 08:21 AM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky wrote:

On 09/18/2014 12:53 PM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky_ching@xxxxxxxxxxxxxx wrote:

From: Micky Ching <micky_ching@xxxxxxxxxxxxxx>

Fix rts5227&5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead resume fail.

Signed-off-by: Micky Ching <micky_ching@xxxxxxxxxxxxxx>
drivers/mfd/rts5227.c | 19 +++++++++++++++++++
drivers/mfd/rts5249.c | 4 ++++
drivers/mfd/rtsx_pcr.h | 1 +
include/linux/mfd/rtsx_pci.h | 12 ++++++++++++
4 files changed, 36 insertions(+)
I think you'll find you just broke the build.

What happens when you compile these as modules?
I build as modules with no warning or error, did you find anything wrong?
Yes, you don't export the functions.

No need export symbol, all rts52xx.c and rtsx_pcr.c will build into a single rtsx_pci.ko file.
and we do not want these functions to be called in other place.
Because they are not a good interface, and may be changed in the future.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at