Re: [PATCH] staging: lustre: llite: Use kzalloc and rewrite null tests
From: Dan Carpenter
Date: Fri Sep 19 2014 - 05:12:28 EST
On Fri, Sep 19, 2014 at 02:57:03AM +0000, Drokin, Oleg wrote:
> 4. Sometimes we need large allocations. general kmalloc is less
> reliable as system lives on and memory fragmentation worsens. So we
> have this "allocations over 2-4 pages get switched to vmalloc" logic,
> if there's a way to do that automatically - that would be great.
Julia's patch only changes OBD_ALLOC() functions and those are always
kmalloc so that's not an issue here.
The OBD_ALLOC_LARGE() macro is vmalloc() or kmalloc() if the size is
small enough. We don't really want to choose between kmalloc and
vmalloc automatically. My instinct is that we should change all the
OBD_ALLOC_LARGE() to vmalloc() and trust it to allocate them in the most
sane way possible. But I haven't really looked very closely.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/