Re: [PATCH] staging: wlan-ng: remove unused 'result' var

From: Sudip Mukherjee
Date: Sat Sep 20 2014 - 14:17:11 EST


On Sat, Sep 20, 2014 at 12:09:11PM +0100, Grzegorz Swirski wrote:
> Signed-off-by: Grzegorz Swirski <grzegorz@xxxxxxxxxxxx>
you have not mentioned any commit log

> ---
> drivers/staging/wlan-ng/prism2mib.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/prism2mib.c b/drivers/staging/wlan-ng/prism2mib.c
> index f471708..0163e06 100644
> --- a/drivers/staging/wlan-ng/prism2mib.c
> +++ b/drivers/staging/wlan-ng/prism2mib.c
> @@ -717,8 +717,6 @@ static int prism2mib_priv(struct mibrec *mib,
> {
> p80211pstrd_t *pstr = (p80211pstrd_t *) data;
>
> - int result;
> -
> switch (mib->did) {
> case DIDmib_lnx_lnxConfigTable_lnxRSNAIE:{
> hfa384x_WPAData_t wpa;
> @@ -734,11 +732,10 @@ static int prism2mib_priv(struct mibrec *mib,
> wpa.datalen = cpu_to_le16(pstr->len);
> memcpy(wpa.data, pstr->data, pstr->len);
>
> - result =
> - hfa384x_drvr_setconfig(hw,
> - HFA384x_RID_CNFWPADATA,
> - (u8 *) &wpa,
> - sizeof(wpa));
> + hfa384x_drvr_setconfig(hw,
> + HFA384x_RID_CNFWPADATA,
> + (u8 *) &wpa,
if you check your patch with --strict option then you will see one warning here.

thanks
sudip
> + sizeof(wpa));
> }
> break;
> }
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/