Re: [PATCH 2/3] x86, ptdump: Simplify page flag evaluation code

From: Ingo Molnar
Date: Sun Sep 21 2014 - 03:05:35 EST



* Mathias Krause <minipli@xxxxxxxxxxxxxx> wrote:

> -#define pt_dump_seq_printf(m, to_dmesg, fmt, args...) \
> +#define ptd_print(m, to_dmesg, fmt, args...) \

Please don't abbreviate to non-obvious shortcuts ('ptd'), keep
using the pt_dump_ prefix which was just fine.

(If checkpatch complains about lines slightly above 80cols then
ignore checkpatch, don't uglify the code.)

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/