Re: [PATCH v2] power: reset: use restart_notifier mechanism for msm-poweroff

From: Stephen Boyd
Date: Mon Sep 22 2014 - 13:30:48 EST


On 09/22, Pramod Gurav wrote:
> diff --git a/drivers/power/reset/msm-poweroff.c b/drivers/power/reset/msm-poweroff.c
> index 774f9a3..db73238 100644
> --- a/drivers/power/reset/msm-poweroff.c
> +++ b/drivers/power/reset/msm-poweroff.c
> @@ -24,17 +24,24 @@
> #include <asm/system_misc.h>

We can remove this include now too?

>
> static void __iomem *msm_ps_hold;
> -
[...]
> @@ -47,8 +54,10 @@ static int msm_restart_probe(struct platform_device *pdev)
> if (IS_ERR(msm_ps_hold))
> return PTR_ERR(msm_ps_hold);
>
> + register_restart_handler(&restart_nb);
> +
> pm_power_off = do_msm_poweroff;
> - arm_pm_restart = do_msm_restart;
> +

And it looks like we should be including <linux/pm.h> for the
pm_power_off hook?

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/